Bug in ExtractFrame API (extracts frames incorrectly)

Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames correctly.

Issue: This API was calculating the file_header and frame_header offset only for the first frame which is not the right logic. We need to skip the file and frame header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761
Committed: https://crrev.com/1b5b22dc1797e38a0e6fcce59cf2b6ea92dfcccc
Cr-Commit-Position: refs/heads/master@{#15288}

[charujain, 2016-11-28 14:58:11]

Description was changed from

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

BUG=webrtc:6761
==========

to

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

BUG=webrtc:6761
==========

[charujain, 2016-11-28 18:11:31]

Patchset #5 (id:40001) has been deleted

[charujain, 2016-11-28 18:11:36]

Patchset #4 (id:30001) has been deleted

[charujain, 2016-11-28 18:11:40]

Patchset #3 (id:20001) has been deleted

[charujain, 2016-11-28 18:11:45]

Patchset #2 (id:10001) has been deleted

[charujain, 2016-11-28 18:12:04]

charujain@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[charujain, 2016-11-28 18:12:20]

Created new patch set.

[phoglund, 2016-11-29 09:38:38]

lgtm

[charujain, 2016-11-29 09:40:10]

Description was changed from

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

BUG=webrtc:6761
==========

to

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true

BUG=webrtc:6761
==========

[charujain, 2016-11-29 09:40:27]

The CQ bit was checked by charujain@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 09:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:59:08]

Dry run: This issue passed the CQ dry run.

[charujain, 2016-11-29 10:00:33]

Description was changed from

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true

BUG=webrtc:6761
==========

to

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761
==========

[charujain, 2016-11-29 10:00:42]

The CQ bit was checked by charujain@webrtc.org

[commit-bot: I haz the power, 2016-11-29 10:00:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 10:00:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480413642596680, "parent_rev":
"732e87fc9b8b6e60d38b1cf5bbc4cc4f8c1efc28", "commit_rev":
"dd34a7db6653f0aac26fe576c4599b12915095cc"}

[commit-bot: I haz the power, 2016-11-29 10:00:56]

Description was changed from

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761
==========

to

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761
==========

[commit-bot: I haz the power, 2016-11-29 10:00:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 10:01:32]

Description was changed from

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761
==========

to

==========
Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames
correctly.

Issue: This API was calculating the file_header and frame_header offset only for
the first frame which is not the right logic. We need to skip the file and frame
header every time we extract a new frame.

Also added a unit test case which compares the extracted frame with the frame
stored in text file.

NOPRESUBMIT=true
NOTRY=true

BUG=webrtc:6761

Committed: https://crrev.com/1b5b22dc1797e38a0e6fcce59cf2b6ea92dfcccc
Cr-Commit-Position: refs/heads/master@{#15288}
==========

[commit-bot: I haz the power, 2016-11-29 10:01:33]

Patchset 1 (id:??) landed as
https://crrev.com/1b5b22dc1797e38a0e6fcce59cf2b6ea92dfcccc
Cr-Commit-Position: refs/heads/master@{#15288}

[kjellander_webrtc, 2016-11-29 10:21:03]

On 2016/11/29 10:01:33, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/1b5b22dc1797e38a0e6fcce59cf2b6ea92dfcccc
> Cr-Commit-Position: refs/heads/master@{#15288}

I didn't realize reference_less_video_test_file.y4m is a whopping 100MB big. Is
this really needed? Our resources/ is heavy as it is.