Added webrtc/audio/utility directory and empty GN target.

Added webrtc/audio/utility directory and empty GN target.

This Cl is the first step of a 3-step process to trick the build system of a
webrtc dependency into not failing.

The second step will be to register this folder in the dependency
build system. It cannot be done first, because there must be a GN
dependency from some existing target to a target in the new folder.

The third step is to land https://codereview.webrtc.org/2424173003, in
which the webrtc/audio/utility is used.

When a new folder with a publicly visible header is added, the build
files of said build system must be manually updated to register the
new folder.

BUG=webrtc:6548
Committed: https://crrev.com/939e08f5f4b167451253d3acd5663dd9ead25875
Cr-Commit-Position: refs/heads/master@{#15299}

[aleloi, 2016-11-29 13:58:53]

aleloi@webrtc.org changed reviewers:
+ solenberg@chromium.org

[aleloi, 2016-11-29 13:58:53]

Hi! Can you take a look at this? It's a very small change that I think needs to
be done if we are to land the AudioFrame and AudioFrameOperations change without
breaking internal projects.

[the sun, 2016-11-29 14:46:11]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-11-29 14:46:11]

lgtm

[aleloi, 2016-11-29 14:53:37]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-11-29 14:53:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 15:32:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480431217891540, "parent_rev":
"a3f3a2795cd6feaea357313eaf71495b90637e3e", "commit_rev":
"f56e3309cdc27d5086d8a40263fa4f2d1fa6c4f6"}

[commit-bot: I haz the power, 2016-11-29 15:32:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 15:32:19]

Description was changed from

==========
Added webrtc/audio/utility directory and empty GN target.

This Cl is the first step of a 3-step process to trick the build system of a
webrtc dependency into not failing.

The second step will be to register this folder in the dependency
build system. It cannot be done first, because there must be a GN
dependency from some existing target to a target in the new folder.

The third step is to land https://codereview.webrtc.org/2424173003, in
which the webrtc/audio/utility is used.

When a new folder with a publicly visible header is added, the build
files of said build system must be manually updated to register the
new folder.

BUG=webrtc:6548
==========

to

==========
Added webrtc/audio/utility directory and empty GN target.

This Cl is the first step of a 3-step process to trick the build system of a
webrtc dependency into not failing.

The second step will be to register this folder in the dependency
build system. It cannot be done first, because there must be a GN
dependency from some existing target to a target in the new folder.

The third step is to land https://codereview.webrtc.org/2424173003, in
which the webrtc/audio/utility is used.

When a new folder with a publicly visible header is added, the build
files of said build system must be manually updated to register the
new folder.

BUG=webrtc:6548

Committed: https://crrev.com/939e08f5f4b167451253d3acd5663dd9ead25875
Cr-Commit-Position: refs/heads/master@{#15299}
==========

[commit-bot: I haz the power, 2016-11-29 15:32:20]

Patchset 1 (id:??) landed as
https://crrev.com/939e08f5f4b167451253d3acd5663dd9ead25875
Cr-Commit-Position: refs/heads/master@{#15299}

[kjellander_webrtc, 2016-11-30 18:19:28]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-11-30 18:19:29]

Wouldn't it be a lot easier to not add a BUILD.gn file in webrtc/audio/utility
and just use the one in webrtc/audio/ ?

[aleloi, 2016-11-30 19:00:52]

On 2016/11/30 18:19:29, kjellander_webrtc wrote:
> Wouldn't it be a lot easier to not add a BUILD.gn file in webrtc/audio/utility
> and just use the one in webrtc/audio/ ?

Ah! Didn't think of that. Well yes, given that we have to do this 3-stage setup,
it would have been simpler to put the target in the BUILD.gn file above. I guess
it will be a lesson for me for the next time. But now we have this setup, I
think we should keep it. Also, the GN style guidelines say something about
having build files closer to the source IIRC.

[the sun, 2016-12-01 08:29:34]

On 2016/11/30 19:00:52, aleloi wrote:
> On 2016/11/30 18:19:29, kjellander_webrtc wrote:
> > Wouldn't it be a lot easier to not add a BUILD.gn file in
webrtc/audio/utility
> > and just use the one in webrtc/audio/ ?
> 
> Ah! Didn't think of that. Well yes, given that we have to do this 3-stage
setup,
> it would have been simpler to put the target in the BUILD.gn file above. I
guess
> it will be a lesson for me for the next time. But now we have this setup, I
> think we should keep it. Also, the GN style guidelines say something about
> having build files closer to the source IIRC.

I find it hard to navigate the large BUILD.gn files with many targets, so adding
a small one close to the sources is what I'd prefer, but perhaps I need to
re-evaluate if it adds a lot of extra configuration work...

[the sun, 2016-12-01 08:30:05]

Description was changed from

==========
Added webrtc/audio/utility directory and empty GN target.

This Cl is the first step of a 3-step process to trick the build system of a
webrtc dependency into not failing.

The second step will be to register this folder in the dependency
build system. It cannot be done first, because there must be a GN
dependency from some existing target to a target in the new folder.

The third step is to land https://codereview.webrtc.org/2424173003, in
which the webrtc/audio/utility is used.

When a new folder with a publicly visible header is added, the build
files of said build system must be manually updated to register the
new folder.

BUG=webrtc:6548

Committed: https://crrev.com/939e08f5f4b167451253d3acd5663dd9ead25875
Cr-Commit-Position: refs/heads/master@{#15299}
==========

to

==========
Added webrtc/audio/utility directory and empty GN target.

This Cl is the first step of a 3-step process to trick the build system of a
webrtc dependency into not failing.

The second step will be to register this folder in the dependency
build system. It cannot be done first, because there must be a GN
dependency from some existing target to a target in the new folder.

The third step is to land https://codereview.webrtc.org/2424173003, in
which the webrtc/audio/utility is used.

When a new folder with a publicly visible header is added, the build
files of said build system must be manually updated to register the
new folder.

BUG=webrtc:6548

Committed: https://crrev.com/939e08f5f4b167451253d3acd5663dd9ead25875
Cr-Commit-Position: refs/heads/master@{#15299}
==========

[the sun, 2016-12-01 08:30:05]

solenberg@webrtc.org changed reviewers:
- solenberg@chromium.org