Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2532113002: Only create |remote_rate| when needed in RemoteBitrateEstimatorSingleStream. (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only create |remote_rate| when needed in RemoteBitrateEstimatorSingleStream. R=stefan@webrtc.org BUG=None Committed: https://crrev.com/ec1a670167c8eb02bea11fb944b6bedf4ddca63a Cr-Commit-Position: refs/heads/master@{#15264}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 4 chunks +13 lines, -7 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
brandtr
https://codereview.webrtc.org/2532113002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc (right): https://codereview.webrtc.org/2532113002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc#newcode136 webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc:136: GetRemoteRate()->TimeToReduceFurther(now_ms, *incoming_bitrate_bps))) { This change (and the one at ...
4 years ago (2016-11-28 13:17:18 UTC) #1
stefan-webrtc
lgtm
4 years ago (2016-11-28 13:18:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532113002/1
4 years ago (2016-11-28 13:19:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15274)
4 years ago (2016-11-28 13:31:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532113002/1
4 years ago (2016-11-28 13:34:52 UTC) #8
brandtr
4 years ago (2016-11-28 13:48:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec1a670167c8eb02bea11fb944b6bedf4ddca63a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698