Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2531993003: MB: Remove a --target-devices-file flag for JUnit tests on android. (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Remove a --target-devices-file flag for JUnit tests on android. Not needed since it doesn't run in a device. It will enable us to run JUnit tests on android on swarming too :) and more good stuff like flakiness dashboard BUG=chromium:497757 R=kjellander@webrtc.org Committed: https://crrev.com/e1a13f8b3ce11f96a0f084fcfbc862371f1de1a1 Cr-Commit-Position: refs/heads/master@{#15268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/mb/mb.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ehmaldonado_webrtc
4 years ago (2016-11-28 14:24:15 UTC) #1
kjellander_webrtc
lgtm but please run trybots
4 years ago (2016-11-28 14:37:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2531993003/1
4 years ago (2016-11-28 14:51:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 15:14:12 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 15:14:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1a13f8b3ce11f96a0f084fcfbc862371f1de1a1
Cr-Commit-Position: refs/heads/master@{#15268}

Powered by Google App Engine
This is Rietveld 408576698