Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2531893002: Revert of Move ADM specific Android files into modules/audio_device/android/ (Closed)

Created:
4 years ago by the sun
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move ADM specific Android files into modules/audio_device/android/ (patchset #2 id:20001 of https://codereview.webrtc.org/2533573002/ ) Reason for revert: Breaks downstream code Original issue's description: > Move ADM specific Android files into modules/audio_device/android/ > > - Move helpers_android.* and jvm_android.* from modules/utility/. > > BUG=none > TBR=perkj@webrtc.org > > Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e > Cr-Commit-Position: refs/heads/master@{#15253} TBR=henrika@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/71b9b58a3a3ac651e5a5c5d095411620bb425659 Cr-Commit-Position: refs/heads/master@{#15254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -697 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/android/build_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/build_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/ensure_initialized.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_device/android/helpers_android.h View 1 chunk +0 lines, -89 lines 0 comments Download
D webrtc/modules/audio_device/android/helpers_android.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D webrtc/modules/audio_device/android/jvm_android.h View 1 chunk +0 lines, -187 lines 0 comments Download
D webrtc/modules/audio_device/android/jvm_android.cc View 1 chunk +0 lines, -276 lines 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/opensles_recorder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/helpers_android.h View 1 chunk +87 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/jvm_android.h View 1 chunk +187 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/helpers_android.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/jvm_android.cc View 1 chunk +276 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
Created Revert of Move ADM specific Android files into modules/audio_device/android/
4 years ago (2016-11-25 19:44:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2531893002/1
4 years ago (2016-11-25 19:45:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 19:45:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71b9b58a3a3ac651e5a5c5d095411620bb425659 Cr-Commit-Position: refs/heads/master@{#15254}
4 years ago (2016-11-25 19:45:20 UTC) #7
henrika_webrtc
4 years ago (2016-11-28 08:04:49 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698