Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: webrtc/modules/video_coding/video_coding_impl.h

Issue 2531383002: Wire up BitrateAllocation to be sent as RTCP TargetBitrate (Closed)
Patch Set: Flaky test, racy shutdown Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/video_coding_impl.h
diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h
index b76c61753a5dd3396169ed433a76911a0d24e558..3a39292d646d53b3b0885a9a8d3320756e5bd175 100644
--- a/webrtc/modules/video_coding/video_coding_impl.h
+++ b/webrtc/modules/video_coding/video_coding_impl.h
@@ -35,6 +35,7 @@
namespace webrtc {
class VideoBitrateAllocator;
+class VideoBitrateAllocationObserver;
namespace vcm {
@@ -79,14 +80,18 @@ class VideoSender : public Module {
int Bitrate(unsigned int* bitrate) const;
int FrameRate(unsigned int* framerate) const;
- int32_t SetChannelParameters(uint32_t target_bitrate_bps,
- uint8_t lossRate,
- int64_t rtt,
- VideoBitrateAllocator* bitrate_allocator);
+ int32_t SetChannelParameters(
+ uint32_t target_bitrate_bps,
+ uint8_t lossRate,
+ int64_t rtt,
+ VideoBitrateAllocator* bitrate_allocator,
+ VideoBitrateAllocationObserver* bitrate_observer);
// Updates the channel parameters, with a reallocated bitrate based on a
// presumably updated codec configuration, but does not update the encoder
// itself (it will be updated on the next frame).
- void UpdateChannelParemeters(VideoBitrateAllocator* bitrate_allocator);
+ void UpdateChannelParemeters(
+ VideoBitrateAllocator* bitrate_allocator,
+ VideoBitrateAllocationObserver* bitrate_observer);
// Deprecated:
// TODO(perkj): Remove once no projects use it.
@@ -105,7 +110,8 @@ class VideoSender : public Module {
EncoderParameters UpdateEncoderParameters(
const EncoderParameters& params,
VideoBitrateAllocator* bitrate_allocator,
- uint32_t target_bitrate_bps);
+ uint32_t target_bitrate_bps,
+ VideoBitrateAllocationObserver* bitrate_observer);
void SetEncoderParameters(EncoderParameters params, bool has_internal_source)
EXCLUSIVE_LOCKS_REQUIRED(encoder_crit_);

Powered by Google App Engine
This is Rietveld 408576698