Wire up BitrateAllocation to be sent as RTCP TargetBitrate

webrtc/modules/video_coding/video_coding_impl.h

Index: webrtc/modules/video_coding/video_coding_impl.h
diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h
index b76c61753a5dd3396169ed433a76911a0d24e558..e5a0c8ac8a035f6f419398b58b2da82a95321422 100644
--- a/webrtc/modules/video_coding/video_coding_impl.h
+++ b/webrtc/modules/video_coding/video_coding_impl.h
@@ -35,6 +35,7 @@
 namespace webrtc {
 
 class VideoBitrateAllocator;
+class VideoBitrateAllocationObserver;
 
 namespace vcm {
 
@@ -79,14 +80,18 @@ class VideoSender : public Module {
   int Bitrate(unsigned int* bitrate) const;
   int FrameRate(unsigned int* framerate) const;
 
-  int32_t SetChannelParameters(uint32_t target_bitrate_bps,
-                               uint8_t lossRate,
-                               int64_t rtt,
-                               VideoBitrateAllocator* bitrate_allocator);
+  int32_t SetChannelParameters(
+      uint32_t target_bitrate_bps,
+      uint8_t lossRate,

[stefan-webrtc, 2016/12/01 08:42:20]

Please change to loss_rate

[sprang_webrtc, 2016/12/01 10:47:58]

Done.

+      int64_t rtt,
+      VideoBitrateAllocator* bitrate_allocator,
+      VideoBitrateAllocationObserver* bitrate_updated_callback);
   // Updates the channel parameters, with a reallocated bitrate based on a
   // presumably updated codec configuration, but does not update the encoder
   // itself (it will be updated on the next frame).
-  void UpdateChannelParemeters(VideoBitrateAllocator* bitrate_allocator);
+  void UpdateChannelParemeters(

[stefan-webrtc, 2016/12/01 08:42:20]

I think it would be good to clarify what the difference is between this method
and SetChannelParameters. When should this be used and how does it differ from
the other one?

[sprang_webrtc, 2016/12/01 10:47:58]

Done.

+      VideoBitrateAllocator* bitrate_allocator,
+      VideoBitrateAllocationObserver* bitrate_updated_callback);
 
   // Deprecated:
   // TODO(perkj): Remove once no projects use it.
@@ -105,7 +110,8 @@ class VideoSender : public Module {
   EncoderParameters UpdateEncoderParameters(
       const EncoderParameters& params,
       VideoBitrateAllocator* bitrate_allocator,
-      uint32_t target_bitrate_bps);
+      uint32_t target_bitrate_bps,
+      VideoBitrateAllocationObserver* bitrate_updated_callback);
   void SetEncoderParameters(EncoderParameters params, bool has_internal_source)
       EXCLUSIVE_LOCKS_REQUIRED(encoder_crit_);