Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2530653003: Adding packet overhead to audio network adaptor. (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding packet overhead to audio network adaptor. BUG=webrtc:6303, webrtc:6762 Committed: https://crrev.com/c9e80eee514a3db7b66f49c02e62e3d5b1f89a9d Cr-Commit-Position: refs/heads/master@{#15305}

Patch Set 1 #

Total comments: 1

Patch Set 2 : adding field trial #

Messages

Total messages: 20 (10 generated)
minyue-webrtc
Hi Michael, Would you take a look at this CL?
4 years ago (2016-11-23 21:39:57 UTC) #3
minyue-webrtc
+Henrik, Michael has seen this CL. PTAL also.
4 years ago (2016-11-24 08:39:09 UTC) #7
hlundin-webrtc
lgtm
4 years ago (2016-11-24 08:49:01 UTC) #8
minyue-webrtc
Thanks! Will do one more change when another CL is landed, and then submit this ...
4 years ago (2016-11-24 09:03:47 UTC) #9
michaelt
lgtm
4 years ago (2016-11-24 10:35:18 UTC) #10
minyue-webrtc
I added field trial according to https://codereview.webrtc.org/2517243005/
4 years ago (2016-11-25 11:34:39 UTC) #11
minyue-webrtc
On 2016/11/25 11:34:39, minyue-webrtc wrote: > I added field trial according to https://codereview.webrtc.org/2517243005/ Given https://codereview.webrtc.org/2517243005/ ...
4 years ago (2016-11-28 21:28:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2530653003/20001
4 years ago (2016-11-29 20:29:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 21:00:32 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-29 21:00:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9e80eee514a3db7b66f49c02e62e3d5b1f89a9d
Cr-Commit-Position: refs/heads/master@{#15305}

Powered by Google App Engine
This is Rietveld 408576698