Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2530363002: Cleanup RtpSender hiding RtpHeaderExtensionLength function. (Closed)

Created:
4 years ago by danilchap
Modified:
4 years ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup RtpSender hiding RtpHeaderExtensionLength function. This function has no public use, removed tests calling it: effect of registering extension is better tested in AllocatePacket and SendPacket tests. BUG=webrtc:5565 Committed: https://crrev.com/e441bdb74407dcd0235146086f662d98e886a8da Cr-Commit-Position: refs/heads/master@{#15258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -110 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
4 years ago (2016-11-28 10:05:02 UTC) #2
sprang_webrtc
lgtm "+1 line, -110 lines" Woo! :)
4 years ago (2016-11-28 10:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2530363002/1
4 years ago (2016-11-28 10:22:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 10:55:01 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-28 10:55:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e441bdb74407dcd0235146086f662d98e886a8da
Cr-Commit-Position: refs/heads/master@{#15258}

Powered by Google App Engine
This is Rietveld 408576698