Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2529943002: Revert of Reland "Move smoothing filter to common audio". (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhuangzesen_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reland "Move smoothing filter to common audio". (patchset #5 id:100001 of https://codereview.webrtc.org/2520003005/ ) Reason for revert: Internal bots failed. Original issue's description: > Reland "Move smoothing filter to common audio". > > The original CL was this https://codereview.webrtc.org/2484153002/ > > Due to failure with internal trial servers, it was reverted. This CL tries to reland it. > > BUG=webrtc:6443 > > Committed: https://crrev.com/223641f1b903e41e77d88f03199b4cdb65255ec8 > Cr-Commit-Position: refs/heads/master@{#15227} TBR=tommi@webrtc.org,solenberg@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6443 Committed: https://crrev.com/3c3aef44deb4cca21ece8532e8dfae1b92c7989a Cr-Commit-Position: refs/heads/master@{#15228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -449 lines) Patch
M webrtc/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
D webrtc/base/analytics/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D webrtc/base/analytics/exp_filter.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/base/analytics/exp_filter.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/base/analytics/exp_filter_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
A webrtc/base/exp_filter.h View 1 chunk +49 lines, -0 lines 0 comments Download
A webrtc/base/exp_filter.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A webrtc/base/exp_filter_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
D webrtc/common_audio/mocks/mock_smoothing_filter.h View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/common_audio/smoothing_filter.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/common_audio/smoothing_filter.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/common_audio/smoothing_filter_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc View 4 chunks +4 lines, -1 line 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_smoothing_filter.h View 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.h View 1 chunk +54 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/frame_dropper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
minyue-webrtc
Created Revert of Reland "Move smoothing filter to common audio".
4 years ago (2016-11-24 15:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2529943002/1
4 years ago (2016-11-24 15:13:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 15:13:22 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-24 15:13:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c3aef44deb4cca21ece8532e8dfae1b92c7989a
Cr-Commit-Position: refs/heads/master@{#15228}

Powered by Google App Engine
This is Rietveld 408576698