Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2529153002: Reland of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (patchset #1 id:1 of https://codereview.webrtc.org/2529143002/ ) Reason for revert: Include fix; set profile information in CreatePayloadType for video. Original issue's description: > Revert of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (patchset #1 id:40001 of https://codereview.webrtc.org/2525693003/ ) > > Reason for revert: > The CL doesn't actually set profile information in VideoPayload. > > Original issue's description: > > Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload > > > > It's necessary to check H264 profile information as well as payload name > > in PayloadIsCompatible in RTPPayloadRegistry. > > > > BUG=webrtc:6743 > > > > Committed: https://crrev.com/bdbc4b7ef578ba1d61ceec351bc47c33da115329 > > Cr-Commit-Position: refs/heads/master@{#15248} > > TBR=mflodman@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6743 > > Committed: https://crrev.com/d7e6ccbc53fc24acdcc7507a6f3a155626473d54 > Cr-Commit-Position: refs/heads/master@{#15251} TBR=mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6743 Committed: https://crrev.com/e69a1a93427f44f7c3deb734c4c492ccd4fb63aa Cr-Commit-Position: refs/heads/master@{#15252}

Patch Set 1 #

Patch Set 2 : Set profile information in CreatePayloadType for video. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M webrtc/common_types.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/common_video/h264/profile_level_id.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
magjed_webrtc
Created Reland of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload
4 years ago (2016-11-25 17:35:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2529153002/160001
4 years ago (2016-11-25 18:06:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:160001)
4 years ago (2016-11-25 18:06:34 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-25 18:06:42 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e69a1a93427f44f7c3deb734c4c492ccd4fb63aa
Cr-Commit-Position: refs/heads/master@{#15252}

Powered by Google App Engine
This is Rietveld 408576698