Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2529143002: Revert of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (patchset #1 id:40001 of https://codereview.webrtc.org/2525693003/ ) Reason for revert: The CL doesn't actually set profile information in VideoPayload. Original issue's description: > Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload > > It's necessary to check H264 profile information as well as payload name > in PayloadIsCompatible in RTPPayloadRegistry. > > BUG=webrtc:6743 > > Committed: https://crrev.com/bdbc4b7ef578ba1d61ceec351bc47c33da115329 > Cr-Commit-Position: refs/heads/master@{#15248} TBR=mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6743 Committed: https://crrev.com/d7e6ccbc53fc24acdcc7507a6f3a155626473d54 Cr-Commit-Position: refs/heads/master@{#15251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M webrtc/common_types.h View 2 chunks +0 lines, -14 lines 0 comments Download
M webrtc/common_video/h264/profile_level_id.h View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
Created Revert of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload
4 years ago (2016-11-25 17:33:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2529143002/1
4 years ago (2016-11-25 17:34:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 17:34:13 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7e6ccbc53fc24acdcc7507a6f3a155626473d54 Cr-Commit-Position: refs/heads/master@{#15251}
4 years ago (2016-11-25 17:34:23 UTC) #7
magjed_webrtc
4 years ago (2016-11-25 17:35:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2529153002/ by magjed@webrtc.org.

The reason for reverting is: Include fix; set profile information in
CreatePayloadType for video..

Powered by Google App Engine
This is Rietveld 408576698