webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc - Issue 2529073003: Fix perf regression in screenshare temporal layer bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Issue 2529073003: Fix perf regression in screenshare temporal layer bitrate allocation (Closed)

Patch Set: Yet another failing test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc ('k') | webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

index 9e8c1c36ffe1952860146e86601df789ded8cbed..b41621c83f88f1849e14a68efc4661030395001c 100644

--- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

@@ -418,6 +418,8 @@ TEST_F(ScreenshareLayerTest, EncoderDrop) {

ConfigureBitrates();

CodecSpecificInfoVP8 vp8_info;

vpx_codec_enc_cfg_t cfg = GetConfig();

+ // Updates cfg with current target bitrate.

+ EXPECT_TRUE(layers_->UpdateConfiguration(&cfg));

uint32_t timestamp = RunGracePeriod();

timestamp = SkipUntilTl(0, timestamp);