Fix perf regression in screenshare temporal layer bitrate allocation

webrtc/modules/video_coding/utility/simulcast_rate_allocator_unittest.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/video_coding/utility/simulcast_rate_allocator.h"
 
 #include <limits>
 #include <memory>
 #include <utility>
 #include <vector>
 
+#include "webrtc/test/gmock.h"
 #include "webrtc/test/gtest.h"
 
 namespace webrtc {
 namespace {
+using ::testing::_;
+
 constexpr uint32_t kMinBitrateKbps = 50;
 constexpr uint32_t kTargetBitrateKbps = 100;
 constexpr uint32_t kMaxBitrateKbps = 1000;
 constexpr uint32_t kFramerateFps = 5;
+
+class MockTemporalLayers : public TemporalLayers {
+ public:
+  MOCK_METHOD1(EncodeFlags, int(uint32_t));
+  MOCK_METHOD3(OnRatesUpdated, std::vector<uint32_t>(int, int, int));
+  MOCK_METHOD1(UpdateConfiguration, bool(vpx_codec_enc_cfg_t*));
+  MOCK_METHOD3(PopulateCodecSpecific,
+               void(bool, CodecSpecificInfoVP8*, uint32_t));
+  MOCK_METHOD3(FrameEncoded, void(unsigned int, uint32_t, int));
+  MOCK_CONST_METHOD0(CurrentLayerId, int());
+};
 }  // namespace
 
 class SimulcastRateAllocatorTest : public ::testing::TestWithParam<bool> {
  public:
   SimulcastRateAllocatorTest() {
     memset(&codec_, 0, sizeof(VideoCodec));
     codec_.minBitrate = kMinBitrateKbps;
     codec_.targetBitrate = kTargetBitrateKbps;
     codec_.maxBitrate = kMaxBitrateKbps;
     CreateAllocator();
@@ skipping 208 matching lines @@
                              codec_.simulcastStream[1].targetBitrate +
                              codec_.simulcastStream[2].maxBitrate;
     uint32_t expected[] = {codec_.simulcastStream[0].targetBitrate,
                            codec_.simulcastStream[1].targetBitrate,
                            codec_.simulcastStream[2].maxBitrate};
     ExpectEqual(expected, GetAllocation(bitrate));
   }
 }
 
 TEST_F(SimulcastRateAllocatorTest, GetPreferredBitrateBps) {
+  MockTemporalLayers mock_layers;
+  allocator_.reset(new SimulcastRateAllocator(codec_, nullptr));
+  allocator_->OnTemporalLayersCreated(0, &mock_layers);
+  EXPECT_CALL(mock_layers, OnRatesUpdated(_, _, _)).Times(0);
   EXPECT_EQ(codec_.maxBitrate * 1000,
             allocator_->GetPreferredBitrateBps(codec_.maxFramerate));
 }
 
 TEST_F(SimulcastRateAllocatorTest, GetPreferredBitrateSimulcast) {
   codec_.numberOfSimulcastStreams = 3;
   codec_.maxBitrate = 999999;
   codec_.simulcastStream[0].minBitrate = 10;
   codec_.simulcastStream[0].targetBitrate = 100;
 
@@ skipping 80 matching lines @@
       allocator_->GetAllocation(kMaxBitrateKbps * 2000, kFramerateFps);
 
   // Fill both TL0 and TL1, but no more.
   EXPECT_EQ(kMaxBitrateKbps, allocation.get_sum_kbps());
   EXPECT_EQ(kTargetBitrateKbps, allocation.GetBitrate(0, 0) / 1000);
   EXPECT_EQ(kMaxBitrateKbps - kTargetBitrateKbps,
             allocation.GetBitrate(0, 1) / 1000);
 }
 
 }  // namespace webrtc