Templatize percentile_filter.h and move it to base/analytics.

Templatize percentile_filter.h and move it to base/analytics.

BUG=None

Committed: https://crrev.com/cb861e074a1988715b5d84511fecdc52b7d7091c
Cr-Commit-Position: refs/heads/master@{#15334}

[terelius, 2016-11-25 10:51:16]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-11-25 10:55:33]

terelius@webrtc.org changed reviewers:
+ magjed@webrtc.org, tommi@webrtc.org

[terelius, 2016-11-25 10:55:34]

I want to move the percentile filter to base/analytics to be able to reuse it in
bandwidth estimation. Please take a look.

[commit-bot: I haz the power, 2016-11-25 11:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:08:28]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-25 12:16:38]

Is it possible to get a better diff of the template change? Can you declare the
class and all functions first and then do the definitions (in the header still)
and do 'git cl upload --similarity=10' and see if you get a better diff?

[terelius, 2016-11-25 13:21:12]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 13:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 13:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 13:23:53]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/18913)

[terelius, 2016-11-25 13:27:54]

On 2016/11/25 12:16:38, magjed_webrtc wrote:
> Is it possible to get a better diff of the template change? Can you declare
the
> class and all functions first and then do the definitions (in the header
still)
> and do 'git cl upload --similarity=10' and see if you get a better diff?

Good suggestion. Done. Also added a simple unit test that instantiates the
template with a couple of different types.

[terelius, 2016-11-25 13:58:18]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 13:58:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 14:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 14:15:18]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-25 14:15:21]

lgtm

[terelius, 2016-11-28 12:37:37]

terelius@webrtc.org changed reviewers:
+ mflodman@webrtc.org
- tommi@webrtc.org

[terelius, 2016-11-28 12:37:38]

Adding mflodman as reviewer for changes in base/ and moving tommi to CC.

[terelius, 2016-11-29 17:43:01]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 17:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 17:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 17:48:41]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/18853)

[magjed_webrtc, 2016-11-30 10:58:25]

You should probably do the moving window changes in a separate follow-up CL to
this.

https://codereview.webrtc.org/2529063002/diff/120001/webrtc/base/analytics/pe...
File webrtc/base/analytics/percentile_filter.h (right):

https://codereview.webrtc.org/2529063002/diff/120001/webrtc/base/analytics/pe...
webrtc/base/analytics/percentile_filter.h:52: std::list<typename
std::multiset<T>::iterator> history_;
An std::queue seems more appropriate. Any reason for not using a queue (e.g.
generated binary size will be bigger)?

https://codereview.webrtc.org/2529063002/diff/120001/webrtc/base/analytics/pe...
webrtc/base/analytics/percentile_filter.h:89: RTC_DCHECK_GT(history_.size(), 0);
nit: I think this is cleaner and will give the same information:
RTC_DCHECK(!history_.empty());

[terelius, 2016-11-30 13:40:35]

On 2016/11/30 10:58:25, magjed_webrtc wrote:
> You should probably do the moving window changes in a separate follow-up CL to
> this.

Done. Removed patch set 7 from this CL.

[mflodman, 2016-11-30 13:47:47]

LGTM

[terelius, 2016-11-30 13:48:04]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 13:48:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 14:17:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:17:31]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-30 14:22:44]

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
File webrtc/base/analytics/percentile_filter.h (right):

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
webrtc/base/analytics/percentile_filter.h:14: #include <stdint.h>
this include looks unused

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
File webrtc/base/analytics/percentile_filter_unittest.cc (right):

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
webrtc/base/analytics/percentile_filter_unittest.cc:28:
PercentileFilter<int64_t> filter_;
This file probably should probably include stdint

[terelius, 2016-11-30 14:32:17]

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
File webrtc/base/analytics/percentile_filter.h (right):

https://codereview.webrtc.org/2529063002/diff/140001/webrtc/base/analytics/pe...
webrtc/base/analytics/percentile_filter.h:14: #include <stdint.h>
On 2016/11/30 14:22:43, magjed_webrtc wrote:
> this include looks unused

It is included for int64_t percentile_index_;

[terelius, 2016-11-30 14:50:12]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2016-11-30 14:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2529063002/#ps140001 (title:
"Move last patch set to a separate CL.")

[commit-bot: I haz the power, 2016-11-30 14:50:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 14:51:57]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480517412920140,
"parent_rev": "38a16e6073eebf325e3158be6dcb0d7a7da5f662", "commit_rev":
"801a1aadc5b20e0332fcc49ef324503ce353af95"}

[commit-bot: I haz the power, 2016-11-30 14:52:04]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-30 14:52:09]

Description was changed from

==========
Templatize percentile_filter.h and move it to base/analytics.

BUG=None
==========

to

==========
Templatize percentile_filter.h and move it to base/analytics.

BUG=None

Committed: https://crrev.com/cb861e074a1988715b5d84511fecdc52b7d7091c
Cr-Commit-Position: refs/heads/master@{#15334}
==========

[commit-bot: I haz the power, 2016-11-30 14:52:10]

Patchset 8 (id:??) landed as
https://crrev.com/cb861e074a1988715b5d84511fecdc52b7d7091c
Cr-Commit-Position: refs/heads/master@{#15334}