Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2528893002: Modify the paths of the resource files to point to chromium/src/tools/... (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Modify the paths of the resource files to point to chromium/src/tools/... R=kjellander@chromium.org BUG=chromium:497757 NOTRY=True Committed: https://crrev.com/d8ae20b362f76d2153fa65b5d82d534c546c59a4 Cr-Commit-Position: refs/heads/master@{#15225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -75 lines) Patch
M tools/valgrind-webrtc/python-google.gni View 1 chunk +17 lines, -17 lines 0 comments Download
M tools/valgrind-webrtc/valgrind.gni View 1 chunk +24 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ehmaldonado_webrtc
I want to try this and see if it works :)
4 years ago (2016-11-24 12:19:54 UTC) #1
ehmaldonado_webrtc
I want to try this and see if it works :)
4 years ago (2016-11-24 12:19:55 UTC) #2
kjellander_webrtc
Ah, I see. So this means we won't be able to use the upstream versions ...
4 years ago (2016-11-24 12:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2528893002/1
4 years ago (2016-11-24 12:32:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 12:34:06 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8ae20b362f76d2153fa65b5d82d534c546c59a4 Cr-Commit-Position: refs/heads/master@{#15225}
4 years ago (2016-11-24 12:34:17 UTC) #12
ehmaldonado_webrtc
4 years ago (2016-11-24 13:16:30 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2532453002/ by ehmaldonado@webrtc.org.

The reason for reverting is: Didn't work.

Powered by Google App Engine
This is Rietveld 408576698