Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2528243003: Remove surface size mismatch logic from EglRenderer. (Closed)

Created:
4 years ago by sakal
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
the sun, tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove surface size mismatch logic from EglRenderer. This logic doesn't really work. Application should mask the view while the surface size is being changed. BUG=webrtc:6470 Committed: https://crrev.com/d1aaaaa125cea9968d101721a109ab9918a871f4 Cr-Commit-Position: refs/heads/master@{#15273}

Patch Set 1 #

Patch Set 2 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
M webrtc/api/android/java/src/org/webrtc/EglRenderer.java View 1 4 chunks +3 lines, -28 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/EglRendererTest.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sakal
PTAL
4 years ago (2016-11-28 13:58:37 UTC) #2
magjed_webrtc
lgtm
4 years ago (2016-11-28 16:29:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2528243003/20001
4 years ago (2016-11-28 16:29:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 16:47:10 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-28 16:47:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1aaaaa125cea9968d101721a109ab9918a871f4
Cr-Commit-Position: refs/heads/master@{#15273}

Powered by Google App Engine
This is Rietveld 408576698