Add I420Buffer::Copy method taking plane pointers as input.

webrtc/common_video/include/video_frame_buffer.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 39 matching lines @@
   // Returns a new memory-backed frame buffer converted from this buffer's
   // native handle.
   virtual rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() = 0;
 
  protected:
   virtual ~VideoFrameBuffer();
 };
 
 // Plain I420 buffer in standard memory.
 class I420Buffer : public VideoFrameBuffer {
- public:
+ protected:
   I420Buffer(int width, int height);
   I420Buffer(int width, int height, int stride_y, int stride_u, int stride_v);
 
+ public:

[magjed_webrtc, 2016/11/28 08:39:56]

The order must be public, protected, private.

[nisse-webrtc, 2016/11/28 09:44:53]

Done.

   static rtc::scoped_refptr<I420Buffer> Create(int width, int height);
   static rtc::scoped_refptr<I420Buffer> Create(int width,
                                                int height,
                                                int stride_y,
                                                int stride_u,
                                                int stride_v);
 
   // Sets all three planes to all zeros. Used to work around for
   // quirks in memory checkers
   // (https://bugs.chromium.org/p/libyuv/issues/detail?id=377) and
@@ skipping 15 matching lines @@
   uint8_t* MutableDataU();
   uint8_t* MutableDataV();
   int StrideY() const override;
   int StrideU() const override;
   int StrideV() const override;
 
   void* native_handle() const override;
   rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override;
 
   // Create a new buffer and copy the pixel data.
   static rtc::scoped_refptr<I420Buffer> Copy(const VideoFrameBuffer& buffer);

[magjed_webrtc, 2016/11/28 08:39:56]

Can you move both these static methods up to the other static methods?

[nisse-webrtc, 2016/11/28 09:44:54]

Done, except for the deprecated version of the Copy method, which is grouped
with the other deprecated methods. 

I guess I should reorder the implementations in the .cc file too, for
consistency?

[magjed_webrtc, 2016/11/28 10:18:20]

Yeah, it's probably best to reorder the .cc file too.

 
+  static rtc::scoped_refptr<I420Buffer> Copy(
+      int width, int height,
+      const uint8_t* data_y, int stride_y,
+      const uint8_t* data_u, int stride_u,
+      const uint8_t* data_v, int stride_v);
+
   // Scale the cropped area of |src| to the size of |this| buffer, and
   // write the result into |this|.
   void CropAndScaleFrom(const VideoFrameBuffer& src,
                         int offset_x,
                         int offset_y,
                         int crop_width,
                         int crop_height);
 
   // The common case of a center crop, when needed to adjust the
   // aspect ratio without distorting the image.
@@ skipping 102 matching lines @@
   const uint8_t* const v_plane_;
   const int y_stride_;
   const int u_stride_;
   const int v_stride_;
   rtc::Callback0<void> no_longer_used_cb_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_VIDEO_INCLUDE_VIDEO_FRAME_BUFFER_H_