Add I420Buffer::Copy method taking plane pointers as input.

webrtc/common_video/i420_video_frame_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 133 matching lines @@
   const int kSizeY = 400;
   const int kSizeU = 100;
   const int kSizeV = 100;
   const VideoRotation kRotation = kVideoRotation_270;
   uint8_t buffer_y[kSizeY];
   uint8_t buffer_u[kSizeU];
   uint8_t buffer_v[kSizeV];
   memset(buffer_y, 16, kSizeY);
   memset(buffer_u, 8, kSizeU);
   memset(buffer_v, 4, kSizeV);
-  // TODO(nisse): This new + Copy looks quite awkward. Consider adding
-  // an alternative I420Buffer::Create method.
+
   VideoFrame frame1(
-      I420Buffer::Copy(*rtc::scoped_refptr<VideoFrameBuffer>(
-          new rtc::RefCountedObject<webrtc::WrappedI420Buffer>(
-              width, height,
-              buffer_y, stride_y,
-              buffer_u, stride_u,
-              buffer_v, stride_v,
-              rtc::Callback0<void>([](){})))),

[nisse-webrtc, 2016/11/25 15:07:46]

The main point of this change is to get rid of this awkward construction. I know
of one downstream project doing the same, and that blocks landing of
https://codereview.webrtc.org/2528143002/

+      I420Buffer::Copy(width, height,
+                       buffer_y, stride_y,
+                       buffer_u, stride_u,
+                       buffer_v, stride_v),
       kRotation, 0);
   frame1.set_timestamp(timestamp);
   frame1.set_ntp_time_ms(ntp_time_ms);
   frame1.set_render_time_ms(render_time_ms);
   VideoFrame frame2(frame1);
 
   EXPECT_EQ(frame1.video_frame_buffer(), frame2.video_frame_buffer());
   EXPECT_EQ(frame1.video_frame_buffer()->DataY(),
             frame2.video_frame_buffer()->DataY());
   EXPECT_EQ(frame1.video_frame_buffer()->DataU(),
@@ skipping 120 matching lines @@
   CheckRotate(640, 480, GetParam(), *rotated_buffer);
 }
 
 INSTANTIATE_TEST_CASE_P(Rotate, TestI420BufferRotate,
                         ::testing::Values(kVideoRotation_0,
                                           kVideoRotation_90,
                                           kVideoRotation_180,
                                           kVideoRotation_270));
 
 }  // namespace webrtc