Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2527903002: Fixed bug in PacketBuffer to correctly detect new complete frames. (Closed)

Created:
4 years ago by philipel
Modified:
4 years ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed bug in PacketBuffer to correctly detect new complete frames after ClearTo has been called. BUG=webrtc:5514 R=stefan@webrtc.org, terelius@webrtc.org Committed: https://crrev.com/20dce34578ae2a7fe11e90a8d15a3784dca3d7e2 Cr-Commit-Position: refs/heads/master@{#15269}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Feedback fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M webrtc/modules/video_coding/packet_buffer.cc View 1 3 chunks +4 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
philipel
4 years ago (2016-11-24 11:27:26 UTC) #3
terelius
lgtm
4 years ago (2016-11-28 12:13:52 UTC) #4
stefan-webrtc
lgtm https://codereview.webrtc.org/2527903002/diff/1/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/2527903002/diff/1/webrtc/modules/video_coding/packet_buffer.cc#newcode194 webrtc/modules/video_coding/packet_buffer.cc:194: PotentialNewFrame(seq_num)) { Might fit on one line?
4 years ago (2016-11-28 13:11:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2527903002/20001
4 years ago (2016-11-28 13:20:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/19833)
4 years ago (2016-11-28 13:39:22 UTC) #10
philipel
Committed patchset #2 (id:20001) manually as 20dce34578ae2a7fe11e90a8d15a3784dca3d7e2 (presubmit successful).
4 years ago (2016-11-28 15:15:09 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 15:15:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20dce34578ae2a7fe11e90a8d15a3784dca3d7e2
Cr-Commit-Position: refs/heads/master@{#15269}

Powered by Google App Engine
This is Rietveld 408576698