webrtc/api/stats/rtcstats_objects.h - Issue 2527113002: Collecting RTCIceCandidatePairStats.transport_id and improved unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2527113002: Collecting RTCIceCandidatePairStats.transport_id and improved unittests (Closed)

Patch Set: Rebase with master and update rtcstats_integrationtest.cc to include transport_id Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/stats/rtcstats_objects.h

diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h

index 0ed02cbb46b389efc874f479b458420e93cc3ab1..8f5e038fc9dec5076e058b08fadee82501907c41 100644

--- a/webrtc/api/stats/rtcstats_objects.h

+++ b/webrtc/api/stats/rtcstats_objects.h

@@ -115,7 +115,6 @@ class RTCIceCandidatePairStats final : public RTCStats {

RTCIceCandidatePairStats(const RTCIceCandidatePairStats& other);

~RTCIceCandidatePairStats() override;

- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550, 653873

RTCStatsMember<std::string> transport_id;

RTCStatsMember<std::string> local_candidate_id;

RTCStatsMember<std::string> remote_candidate_id;

« no previous file with comments | « webrtc/api/stats/rtcstats.h ('k') | webrtc/stats/rtcstats.cc » ('j') | no next file with comments »