Add unit tests for avfoundation format mapper functions and fix wrong implementation.

webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm

Index: webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm b/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm
index 19afa337683bacbeb7b1a14e2cd539cf821b6f09..717b4256492872925b80e1f43e61cd58ca1656b2 100644
--- a/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm
+++ b/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.mm
@@ -27,7 +27,7 @@ static inline BOOL IsFrameRateWithinRange(int fps, AVFrameRateRange* range) {
 
 // Returns filtered array of device formats based on predefined constraints our
 // stack imposes.
-static NSArray<AVCaptureDeviceFormat*>* GetEligibleDeviceFormats(
+NSArray<AVCaptureDeviceFormat*>* GetEligibleDeviceFormats(

[magjed_webrtc, 2016/11/28 12:21:23]

You are not allowed to expose implementation details from .cc or .mm files.
Every exposed function needs to be present in the header file. I understand you
want to test these functions directly, but I discourage you from doing that
since they are implementation details. Test only the public functions
GetSupportedVideoFormatsForDevice and SetFormatForCaptureDevice.

     const AVCaptureDevice* device,
     int supportedFps) {
   NSMutableArray<AVCaptureDeviceFormat*>* eligibleDeviceFormats =
@@ -54,7 +54,7 @@ static NSArray<AVCaptureDeviceFormat*>* GetEligibleDeviceFormats(
 }
 
 // Mapping from cricket::VideoFormat to AVCaptureDeviceFormat.
-static AVCaptureDeviceFormat* GetDeviceFormatForVideoFormat(
+AVCaptureDeviceFormat* GetDeviceFormatForVideoFormat(
     const AVCaptureDevice* device,
     const cricket::VideoFormat& videoFormat) {
   AVCaptureDeviceFormat* desiredDeviceFormat = nil;