Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h

Issue 2526813002: Add unit tests for avfoundation format mapper functions and fix wrong implementation. (Closed)
Patch Set: Rename test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h
diff --git a/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h b/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h
index 9af55e9b0efef21d5c53bf46cd508b83838abe95..b4c69ad6c73b1f6d907b96b2c916db44dc23ab87 100644
--- a/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h
+++ b/webrtc/sdk/objc/Framework/Classes/avfoundationformatmapper.h
@@ -10,18 +10,18 @@
#import <AVFoundation/AVFoundation.h>
#import <Foundation/Foundation.h>
-
+#include <vector>
magjed_webrtc 2016/11/29 16:31:39 nit: You should include set instead. Also, place s
#include "webrtc/media/base/videocapturer.h"
namespace webrtc {
// Mapping from AVCaptureDeviceFormat to cricket::VideoFormat for given input
// device.
-extern std::set<cricket::VideoFormat> GetSupportedVideoFormatsForDevice(
+std::set<cricket::VideoFormat> GetSupportedVideoFormatsForDevice(
AVCaptureDevice* device);
// Sets device format for the provided capture device. Returns YES/NO depending
// on success.
-extern bool SetFormatForCaptureDevice(AVCaptureDevice* device,
- AVCaptureSession* session,
- const cricket::VideoFormat& format);
+bool SetFormatForCaptureDevice(AVCaptureDevice* device,
+ AVCaptureSession* session,
+ const cricket::VideoFormat& format);
}
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698