Only use BoringSSL time callback in unit tests.

Only use BoringSSL time callback in unit tests.

The actual time used in production code should honor the epoch time.

BUG=webrtc:6737
Committed: https://crrev.com/6cf94a01182f366504d3343caaa6732904191bcb
Cr-Commit-Position: refs/heads/master@{#15282}

[Taylor Brandstetter, 2016-11-22 08:54:52]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-11-22 08:54:52]

PTAL Peter. See the bug for an explanation. And let me know if there's a
preferred way to enable something only for tests.

[pthatcher1, 2016-11-29 00:32:40]

Seems fine.  I'm just nit-picking names.

https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
File webrtc/base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.cc:71: static void TimeCallbackForTesting(const
SSL* ssl, struct timeval* out_clock) {
FakeClockTimeCallback?

https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.cc:1271: g_use_time_callback_for_testing =
true;
g_use_fake_clock?

https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
File webrtc/base/opensslstreamadapter.h (right):

https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.h:123: static void
enable_time_callback_for_testing();
EnableFakeClock?

[Taylor Brandstetter, 2016-11-29 00:41:41]

On 2016/11/29 00:32:40, pthatcher1 wrote:
> Seems fine.  I'm just nit-picking names.
> 
>
https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
> File webrtc/base/opensslstreamadapter.cc (right):
> 
>
https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
> webrtc/base/opensslstreamadapter.cc:71: static void
TimeCallbackForTesting(const
> SSL* ssl, struct timeval* out_clock) {
> FakeClockTimeCallback?
> 
>
https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
> webrtc/base/opensslstreamadapter.cc:1271: g_use_time_callback_for_testing =
> true;
> g_use_fake_clock?
> 
>
https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
> File webrtc/base/opensslstreamadapter.h (right):
> 
>
https://codereview.webrtc.org/2526433002/diff/1/webrtc/base/opensslstreamadap...
> webrtc/base/opensslstreamadapter.h:123: static void
> enable_time_callback_for_testing();
> EnableFakeClock?

There's nothing that forces it to be the fake clock, though. For most tests, the
real clock will end up being used.

[pthatcher1, 2016-11-29 00:46:08]

lgtm

[Taylor Brandstetter, 2016-11-29 00:49:54]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-11-29 00:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 00:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:51:16]

Try jobs failed on following builders:
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12870)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/15243)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20459)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19173)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/19786)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/20525)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10735)

[Taylor Brandstetter, 2016-11-29 01:15:43]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-11-29 01:15:44]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2526433002/#ps20001 (title:
"Merging with master.")

[commit-bot: I haz the power, 2016-11-29 01:15:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 01:38:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480382143916130,
"parent_rev": "a39ccbc271bb7ac35da80c0e43b4d59edfd75c19", "commit_rev":
"b1823149bf667a3089e5b3dbe27f2e7d44dd586a"}

[commit-bot: I haz the power, 2016-11-29 01:38:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 01:38:47]

Description was changed from

==========
Only use BoringSSL time callback in unit tests.

The actual time used in production code should honor the epoch time.

BUG=webrtc:6737
==========

to

==========
Only use BoringSSL time callback in unit tests.

The actual time used in production code should honor the epoch time.

BUG=webrtc:6737

Committed: https://crrev.com/6cf94a01182f366504d3343caaa6732904191bcb
Cr-Commit-Position: refs/heads/master@{#15282}
==========

[commit-bot: I haz the power, 2016-11-29 01:38:48]

Patchset 2 (id:??) landed as
https://crrev.com/6cf94a01182f366504d3343caaa6732904191bcb
Cr-Commit-Position: refs/heads/master@{#15282}