Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2526273002: Move helpers_ios.cc/.h (Closed)

Created:
4 years ago by the sun
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move helpers_ios.cc/.h - Out from modules/utility/ and into modules/audio_device/ios/ - there they are used. BUG=none Committed: https://crrev.com/5de9b6a3ec7e909b2628840b50c06a26b28b899d Cr-Commit-Position: refs/heads/master@{#15236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -281 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_device/ios/helpers_ios.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_device/ios/helpers_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/test/audio_device_test_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/test/audio_device_test_defines.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/utility/include/helpers_ios.h View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/modules/utility/source/helpers_ios.mm View 1 chunk +0 lines, -197 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
the sun
4 years ago (2016-11-24 15:32:32 UTC) #2
henrika_webrtc
Thanks! LGTM
4 years ago (2016-11-24 15:40:06 UTC) #3
the sun
+perkj@, OWNER and demi-god of modules/utility/
4 years ago (2016-11-24 15:52:03 UTC) #5
perkj_webrtc
I wonder why. rs lgtm
4 years ago (2016-11-25 08:41:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2526273002/1
4 years ago (2016-11-25 08:45:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 08:47:10 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-25 08:47:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5de9b6a3ec7e909b2628840b50c06a26b28b899d
Cr-Commit-Position: refs/heads/master@{#15236}

Powered by Google App Engine
This is Rietveld 408576698