Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2525943003: Increase the threshold for RunPlayoutAndRecordingInFullDuplex. Again. (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase the threshold for RunPlayoutAndRecordingInFullDuplex. Again. RunPlayoutAndRecordingInFullDuplex fails sometimes on Android swarming bots, presumably because the timing is hardware dependent. This test ensures that audio starts pumping. The exact performance is not that important. R=kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6464 NOTRY=True Committed: https://crrev.com/37a2111d7ce430a32c35183442747868ca9a28c9 Cr-Commit-Position: refs/heads/master@{#15223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ehmaldonado_webrtc
4 years ago (2016-11-23 16:20:41 UTC) #1
kjellander_webrtc
LGTM. Run trybots?
4 years ago (2016-11-23 16:57:28 UTC) #2
henrika_webrtc
LGTM. If it still fails with these settings I can rewrite the test instead.
4 years ago (2016-11-24 09:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2525943003/1
4 years ago (2016-11-24 11:11:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 11:13:20 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-24 11:13:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37a2111d7ce430a32c35183442747868ca9a28c9
Cr-Commit-Position: refs/heads/master@{#15223}

Powered by Google App Engine
This is Rietveld 408576698