Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2525383002: Fix BitrateControllerImpl not to ignore BW probe results mid-call. (Closed)

Created:
4 years ago by philipel
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/branch-heads/55
Project:
webrtc
Visibility:
Public.

Description

Fix BitrateControllerImpl not to ignore BW probe results mid-call. Previously when BitrateControllerImpl::OnDelayBasedBweResult() is called as result of a probe it was calling bandwidth_estimation_.SetSendBitrate(), but not UpdateDelayBasedEstimate(). As result SendSideBandwidthEstimation was effectively ignoring probe results as it kept the old delay_based_bitrate_bps_ value, which caps the resulting bitrate. BUG=webrtc:6332, webrtc:6710 Review-Url: https://codereview.webrtc.org/2481383002 Cr-Commit-Position: refs/heads/master@{#15071} (cherry picked from commit 26b675625f150be1ebc1a2350d39e5116d214871) R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/5ff9cd35c5f5052cc7a9c4a63759cf8d86a5234b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2525383002/1
4 years ago (2016-11-27 13:00:28 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-11-27 13:00:29 UTC) #4
stefan-webrtc
lgtm
4 years ago (2016-11-28 10:44:18 UTC) #6
philipel
4 years ago (2016-11-28 12:03:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ff9cd35c5f5052cc7a9c4a63759cf8d86a5234b.

Powered by Google App Engine
This is Rietveld 408576698