Add overhead to transport feedback observer.

Add overhead to transport feedback observer.

BUG=webrtc:6762
Committed: https://crrev.com/668eb3b71cb1cd3a919e2216783f47e60526a3a1
Cr-Commit-Position: refs/heads/master@{#15291}

[michaelt, 2016-11-24 09:49:50]

Description was changed from

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762
==========

to

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762
==========

[michaelt, 2016-11-24 09:49:51]

michaelt@webrtc.org changed reviewers:
+ minyue@webrtc.org, stefan@webrtc.org

[michaelt, 2016-11-24 09:50:29]

Here my CL which adds overhead to the transport feedback observer.

[stefan-webrtc, 2016-11-28 15:21:11]

lg

https://codereview.webrtc.org/2525283002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2525283002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1561: .Times(1);
Seems like we can skip most of these EXPECT_CALLs, right? The ones on lines
1563-1573 should be enough. Would make it a bit easier to read.

May have to change to a NiceMock

[michaelt, 2016-11-29 08:22:52]

https://codereview.webrtc.org/2525283002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2525283002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1561: .Times(1);
There is still som preparation needed but i could remove quite a bit.

[stefan-webrtc, 2016-11-29 09:05:13]

lgtm

[minyue-webrtc, 2016-11-29 09:24:36]

Good work!

LGTM % nit

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1556: .Times(1);
I am not a fun of Times(1)

According to this
https://github.com/google/googletest/blob/master/googlemock/docs/ForDummies.md

If neither WillOnce() nor WillRepeatedly() is in the EXPECT_CALL(), the inferred
cardinality is Times(1).

[michaelt, 2016-11-29 09:55:53]

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1556: .Times(1);
If some one don't know this rule its may be a bit more clear if you write
Times(1) that the call is expected just once.

[minyue-webrtc, 2016-11-29 09:59:49]

lgtm

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/2525283002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1556: .Times(1);
On 2016/11/29 09:55:53, michaelt wrote:
> If some one don't know this rule its may be a bit more clear if you write
> Times(1) that the call is expected just once. 
> 

Ok. I am not very strong on not using Times(1) either.

[michaelt, 2016-11-29 10:09:17]

The CQ bit was checked by michaelt@webrtc.org

[commit-bot: I haz the power, 2016-11-29 10:09:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 10:24:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480414157804380,
"parent_rev": "ed92410ab1bff3b57312bc6c8b58214880c600a3", "commit_rev":
"93bd9de1f62675ebd1687af14d06b8caef8a05f8"}

[commit-bot: I haz the power, 2016-11-29 10:24:20]

Description was changed from

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762
==========

to

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762
==========

[commit-bot: I haz the power, 2016-11-29 10:24:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 10:24:29]

Description was changed from

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762
==========

to

==========
Add overhead to transport feedback observer.

BUG=webrtc:6762

Committed: https://crrev.com/668eb3b71cb1cd3a919e2216783f47e60526a3a1
Cr-Commit-Position: refs/heads/master@{#15291}
==========

[commit-bot: I haz the power, 2016-11-29 10:24:30]

Patchset 2 (id:??) landed as
https://crrev.com/668eb3b71cb1cd3a919e2216783f47e60526a3a1
Cr-Commit-Position: refs/heads/master@{#15291}