Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2524813002: Really disable Opus complexity tests on Android (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Really disable Opus complexity tests on Android This is a follow-up to https://codereview.webrtc.org/2525603002/, which was incomplete. BUG=webrtc:6708 TBR=philipel@webrtc.org NOTRY=True Committed: https://crrev.com/c1dd1a5916179602be389e1a92ce278b70801d09 Cr-Commit-Position: refs/heads/master@{#15202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2524813002/1
4 years ago (2016-11-22 18:33:33 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/builds/616)
4 years ago (2016-11-22 18:37:03 UTC) #4
kjellander_webrtc
Such a change calls for NOTRY=True and just running a sanity-check trybot, since we're fixing ...
4 years ago (2016-11-22 19:17:20 UTC) #7
kjellander_webrtc
lgtm
4 years ago (2016-11-22 19:17:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2524813002/1
4 years ago (2016-11-22 19:17:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 19:19:15 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-22 19:19:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1dd1a5916179602be389e1a92ce278b70801d09
Cr-Commit-Position: refs/heads/master@{#15202}

Powered by Google App Engine
This is Rietveld 408576698