Adding a unit test for RMSLevel

Adding a unit test for RMSLevel

BUG=webrtc:6622
Committed: https://crrev.com/76622ce3c311e1250a5cee27f1a4d9aa57153812
Cr-Commit-Position: refs/heads/master@{#15242}

[hlundin-webrtc, 2016-11-24 14:22:48]

henrik.lundin@webrtc.org changed reviewers:
+ peah@webrtc.org

[hlundin-webrtc, 2016-11-24 14:22:48]

Per, PTAL.

[peah-webrtc, 2016-11-25 12:25:29]

On 2016/11/24 14:22:48, hlundin-webrtc wrote:
> Per, PTAL.

Nice!

lgtm (some comments/questions though)

[peah-webrtc, 2016-11-25 12:26:25]

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/rms_level_unittest.cc (right):

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:21: constexpr int
kSampleRateHz = 48000;
You probably could (should?) use AudioProcessing::kSampleRate48kHz here. I'm
fine with the current formulation though.

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:28:
level->Process(input.subview(n, kBlockSizeSamples).data(),
Nice!

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:38: const float pi =
std::acos(-1);
Why not use M_PI?

[hlundin-webrtc, 2016-11-25 13:09:00]

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/rms_level_unittest.cc (right):

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:21: constexpr int
kSampleRateHz = 48000;
On 2016/11/25 12:26:25, peah-webrtc wrote:
> You probably could (should?) use AudioProcessing::kSampleRate48kHz here. I'm
> fine with the current formulation though.

Neither the test, nor the code it tests depend on
AudioProcessing::kSampleRateXX. I'd rather not throw in that dependency now.

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:28:
level->Process(input.subview(n, kBlockSizeSamples).data(),
On 2016/11/25 12:26:25, peah-webrtc wrote:
> Nice!

It will be even nicer in the next CL :)

https://codereview.webrtc.org/2524273003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level_unittest.cc:38: const float pi =
std::acos(-1);
On 2016/11/25 12:26:25, peah-webrtc wrote:
> Why not use M_PI?

Done.

[hlundin-webrtc, 2016-11-25 13:11:42]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-11-25 13:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2524273003/#ps60001 (title:
"Review comments")

[commit-bot: I haz the power, 2016-11-25 13:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 13:30:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480079502319980,
"parent_rev": "61ac21cb59ba07452469dc6d838372cde4cd0c40", "commit_rev":
"9c0f5e96ec3f4b90bd6d4b0d62c9f22b73eb8bdf"}

[commit-bot: I haz the power, 2016-11-25 13:30:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-25 13:31:01]

Description was changed from

==========
Adding a unit test for RMSLevel

BUG=webrtc:6622
==========

to

==========
Adding a unit test for RMSLevel

BUG=webrtc:6622

Committed: https://crrev.com/76622ce3c311e1250a5cee27f1a4d9aa57153812
Cr-Commit-Position: refs/heads/master@{#15242}
==========

[commit-bot: I haz the power, 2016-11-25 13:31:02]

Patchset 4 (id:??) landed as
https://crrev.com/76622ce3c311e1250a5cee27f1a4d9aa57153812
Cr-Commit-Position: refs/heads/master@{#15242}