Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: webrtc/api/datachannelinterface.h

Issue 2524033002: DataChannelInterface: Remove default implementation of methods. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/datachannelinterface.h
diff --git a/webrtc/api/datachannelinterface.h b/webrtc/api/datachannelinterface.h
index ddeb1e5636f35c858010ad90d4e4570d8d8bd91e..8b788c04684a70368fa16d6fb113a3ed14e11ce8 100644
--- a/webrtc/api/datachannelinterface.h
+++ b/webrtc/api/datachannelinterface.h
@@ -125,13 +125,10 @@ class DataChannelInterface : public rtc::RefCountInterface {
virtual int id() const = 0;
virtual DataState state() const = 0;
- // TODO(hbos): Default implementations of [messages/bytes]_[sent/received] as
- // to not break Chromium. Fix Chromium's implementation as soon as this rolls.
- // crbug.com/654927
- virtual uint32_t messages_sent() const { return 0; }
- virtual uint64_t bytes_sent() const { return 0; }
- virtual uint32_t messages_received() const { return 0; }
- virtual uint64_t bytes_received() const { return 0; }
+ virtual uint32_t messages_sent() const = 0;
+ virtual uint64_t bytes_sent() const = 0;
+ virtual uint32_t messages_received() const = 0;
+ virtual uint64_t bytes_received() const = 0;
// The buffered_amount returns the number of bytes of application data
// (UTF-8 text and binary data) that have been queued using SendBuffer but
// have not yet been transmitted to the network.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698