Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2524033002: DataChannelInterface: Remove default implementation of methods. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

DataChannelInterface: Remove default implementation of methods. This can land as soon as https://codereview.chromium.org/2520033005/ has landed. BUG=chromium:654927 Committed: https://crrev.com/c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4 Cr-Commit-Position: refs/heads/master@{#15221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M webrtc/api/datachannelinterface.h View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hbos
Please take a look, perkj.
4 years ago (2016-11-23 16:16:39 UTC) #4
perkj_webrtc
lgtm
4 years ago (2016-11-24 08:29:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2524033002/1
4 years ago (2016-11-24 09:16:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 09:17:56 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-24 09:18:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4
Cr-Commit-Position: refs/heads/master@{#15221}

Powered by Google App Engine
This is Rietveld 408576698