Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2524003002: Remove binding framebuffer from GlTextureFrameBuffer.setSize. (Closed)

Created:
4 years ago by sakal
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove binding framebuffer from GlTextureFrameBuffer.setSize. There shouldn't be a need to bind the framebuffer to modify the texture size. Binding the framebuffer causes a crash on Samsung Galaxy S3 mini for some reason. BUG=webrtc:6470 Committed: https://crrev.com/1c82884e315ea4223ce33a746d1f6f106ec29bae Cr-Commit-Position: refs/heads/master@{#15210}

Patch Set 1 #

Patch Set 2 : Add error check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M webrtc/api/android/java/src/org/webrtc/GlTextureFrameBuffer.java View 1 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sakal
PTAL
4 years ago (2016-11-23 11:52:51 UTC) #2
sakal
Forgot to add reviewers. PTAL
4 years ago (2016-11-23 11:53:13 UTC) #4
magjed_webrtc
lgtm
4 years ago (2016-11-23 13:54:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2524003002/20001
4 years ago (2016-11-23 13:56:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 14:12:29 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-23 14:12:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c82884e315ea4223ce33a746d1f6f106ec29bae
Cr-Commit-Position: refs/heads/master@{#15210}

Powered by Google App Engine
This is Rietveld 408576698