Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2523993002: Try to deflake VideoSendStream tests with FlexFEC. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index cc76b13515a54c33a7dce5667c03691b28f8b40b..c02d8d2de3323ba61bb1fddf402675b69f185e3c 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -546,7 +546,6 @@ class FlexfecObserver : public test::EndToEndTest {
: EndToEndTest(VideoSendStreamTest::kDefaultTimeoutMs),
payload_name_(codec),
use_nack_(use_nack),
- send_count_(0),
sent_media_(false),
sent_flexfec_(false),
header_extensions_enabled_(header_extensions_enabled) {
@@ -568,7 +567,6 @@ class FlexfecObserver : public test::EndToEndTest {
RTPHeader header;
EXPECT_TRUE(parser_->Parse(packet, length, &header));
- ++send_count_;
if (header.payloadType == VideoSendStreamTest::kFlexfecPayloadType) {
EXPECT_EQ(VideoSendStreamTest::kFlexfecSendSsrc, header.ssrc);
sent_flexfec_ = true;
@@ -585,7 +583,7 @@ class FlexfecObserver : public test::EndToEndTest {
EXPECT_TRUE(header.extension.hasTransportSequenceNumber);
}
- if (send_count_ > 100 && sent_media_ && sent_flexfec_) {
+ if (sent_media_ && sent_flexfec_) {
observation_complete_.Set();
}
@@ -637,7 +635,6 @@ class FlexfecObserver : public test::EndToEndTest {
std::unique_ptr<VideoEncoder> encoder_;
const std::string payload_name_;
const bool use_nack_;
- int send_count_;
bool sent_media_;
bool sent_flexfec_;
bool header_extensions_enabled_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698