webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc - Issue 2523843002: Send audio and video codecs to RTPPayloadRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

Issue 2523843002: Send audio and video codecs to RTPPayloadRegistry (Closed)

Patch Set: Address comments and add video test for RtpPayloadRegistry Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc b/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

index 90e19c06459ad7c24a3230c53803b835e1755b02..3d51fe010ee28b5352a9cb93728700d8728082c9 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

@@ -44,9 +44,8 @@ bool RTPReceiverVideo::ShouldReportCsrcChanges(uint8_t payload_type) const {

}

int32_t RTPReceiverVideo::OnNewPayloadTypeCreated(

- const char payload_name[RTP_PAYLOAD_NAME_SIZE],

- int8_t payload_type,

- uint32_t frequency) {

+ const CodecInst& audio_codec) {

+ // Ignore, this function will never be called.

danilchap 2016/11/23 17:12:50 use RTC_NOTREACHABLE() instead of the comment to b

magjed_webrtc 2016/11/24 09:39:40 Done.

return 0;

}