Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2523773003: Keep all codec parameters in VideoReceiveStream::Decoder (Closed)
Patch Set: Add common key for sprop-parameter-sets Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/mediaconstants.cc ('k') | webrtc/media/engine/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index 596e7091f73345c485d059f0f0c9d6517bb4af6d..55e6374a2bea35c72da2ec4da3898e020725ec46 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -2276,20 +2276,6 @@ WebRtcVideoChannel2::WebRtcVideoReceiveStream::CreateOrReuseVideoDecoder(
webrtc::kVideoCodecUnknown, false);
}
-void ConfigureDecoderSpecifics(webrtc::VideoReceiveStream::Decoder* decoder,
- const cricket::VideoCodec& recv_video_codec) {
- if (recv_video_codec.name.compare("H264") == 0) {
- auto it = recv_video_codec.params.find("sprop-parameter-sets");
- if (it != recv_video_codec.params.end()) {
- decoder->decoder_specific.h264_extra_settings =
- rtc::Optional<webrtc::VideoDecoderH264Settings>(
- webrtc::VideoDecoderH264Settings());
- decoder->decoder_specific.h264_extra_settings->sprop_parameter_sets =
- it->second;
- }
- }
-}
-
void WebRtcVideoChannel2::WebRtcVideoReceiveStream::ConfigureCodecs(
const std::vector<VideoCodecSettings>& recv_codecs,
std::vector<AllocatedDecoder>* old_decoders) {
@@ -2305,7 +2291,7 @@ void WebRtcVideoChannel2::WebRtcVideoReceiveStream::ConfigureCodecs(
decoder.decoder = allocated_decoder.decoder;
decoder.payload_type = recv_codecs[i].codec.id;
decoder.payload_name = recv_codecs[i].codec.name;
- ConfigureDecoderSpecifics(&decoder, recv_codecs[i].codec);
+ decoder.codec_params = recv_codecs[i].codec.params;
config_.decoders.push_back(decoder);
}
« no previous file with comments | « webrtc/media/base/mediaconstants.cc ('k') | webrtc/media/engine/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698