Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h

Issue 2522553002: RtpPacketizer::NextPacket fills RtpPacket instead of payload. (Closed)
Patch Set: Named kTheMagicSix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h b/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h
index 3feca4392ac93cbdd460df1c8d89f0f87436c6ee..2036ce49f4b2b9d9b75c0c262427fd09db3c7119 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h
@@ -49,15 +49,11 @@ class RtpPacketizerVp9 : public RtpPacketizer {
const RTPFragmentationHeader* fragmentation) override;
// Gets the next payload with VP9 payload header.
- // |buffer| is a pointer to where the output will be written.
- // |bytes_to_send| is an output variable that will contain number of bytes
- // written to buffer.
- // |last_packet| is true for the last packet of the frame, false otherwise
- // (i.e. call the function again to get the next packet).
+ // Write payload and set marker bit of the |packet|.
+ // The parameter |last_packet| is true for the last packet of the frame, false
+ // otherwise (i.e., call the function again to get the next packet).
// Returns true on success, false otherwise.
- bool NextPacket(uint8_t* buffer,
- size_t* bytes_to_send,
- bool* last_packet) override;
+ bool NextPacket(RtpPacketToSend* packet, bool* last_packet) override;
typedef struct {
size_t payload_start_pos;
@@ -76,8 +72,7 @@ class RtpPacketizerVp9 : public RtpPacketizer {
// |bytes_to_send| contains the number of written bytes to the buffer.
// Returns true on success, false otherwise.
bool WriteHeaderAndPayload(const PacketInfo& packet_info,
- uint8_t* buffer,
- size_t* bytes_to_send) const;
+ RtpPacketToSend* packet) const;
// Writes payload descriptor header to |buffer|.
// Returns true on success, false otherwise.
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_vp8_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698