Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h

Issue 2522553002: RtpPacketizer::NextPacket fills RtpPacket instead of payload. (Closed)
Patch Set: Named kTheMagicSix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h b/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h
index d62ecba85fe55eee5352a91e5ecdfe03758f66c2..cddf51f04e07e751e6137fe60f4231687aa34f35 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h
@@ -65,19 +65,11 @@ class RtpPacketizerVp8 : public RtpPacketizer {
const RTPFragmentationHeader* fragmentation) override;
// Get the next payload with VP8 payload header.
- // max_payload_len limits the sum length of payload and VP8 payload header.
- // buffer is a pointer to where the output will be written.
- // bytes_to_send is an output variable that will contain number of bytes
- // written to buffer. Parameter last_packet is true for the last packet of
- // the frame, false otherwise (i.e., call the function again to get the
- // next packet).
- // For the kStrict and kAggregate mode: returns the partition index from which
- // the first payload byte in the packet is taken, with the first partition
- // having index 0; returns negative on error.
- // For the kEqualSize mode: returns 0 on success, return negative on error.
- bool NextPacket(uint8_t* buffer,
- size_t* bytes_to_send,
- bool* last_packet) override;
+ // Write payload and set marker bit of the |packet|.
+ // The parameter |last_packet| is true for the last packet of the frame, false
+ // otherwise (i.e., call the function again to get the next packet).
+ // Returns true on success, false otherwise.
+ bool NextPacket(RtpPacketToSend* packet, bool* last_packet) override;
ProtectionType GetProtectionType() override;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698