Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_format.h

Issue 2522553002: RtpPacketizer::NextPacket fills RtpPacket instead of payload. (Closed)
Patch Set: Named kTheMagicSix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_format_h264.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_format.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_format.h b/webrtc/modules/rtp_rtcp/source/rtp_format.h
index 8cad6a916d0531115049067dbb1d20eb2c57bd04..3b6004b9a13f84e30a5e1ba1611a1c3c68e8696c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_format.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_format.h
@@ -18,6 +18,7 @@
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
namespace webrtc {
+class RtpPacketToSend;
class RtpPacketizer {
public:
@@ -33,15 +34,11 @@ class RtpPacketizer {
const RTPFragmentationHeader* fragmentation) = 0;
// Get the next payload with payload header.
- // buffer is a pointer to where the output will be written.
- // bytes_to_send is an output variable that will contain number of bytes
- // written to buffer. The parameter last_packet is true for the last packet of
- // the frame, false otherwise (i.e., call the function again to get the
- // next packet).
- // Returns true on success or false if there was no payload to packetize.
- virtual bool NextPacket(uint8_t* buffer,
- size_t* bytes_to_send,
- bool* last_packet) = 0;
+ // Write payload and set marker bit of the |packet|.
+ // The parameter |last_packet| is true for the last packet of the frame, false
+ // otherwise (i.e., call the function again to get the next packet).
+ // Returns true on success, false otherwise.
+ virtual bool NextPacket(RtpPacketToSend* packet, bool* last_packet) = 0;
virtual ProtectionType GetProtectionType() = 0;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_format_h264.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698