Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2522543006: AGC: Add a histogram for clipping adjustment (Closed)

Created:
4 years, 1 month ago by hlundin-webrtc
Modified:
4 years, 1 month ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AGC: Add a histogram for clipping adjustment This new histogram will log a value every time input clipping is detected. The value is a boolean, with "true" meaning that the gain was in fact adjusted in response to the detected clipping, and "false" meaning that adjustment was not allowed due to kClippedLevelMin. BUG=webrtc:6622 Committed: https://crrev.com/30a12fbbb9f89959b9a4f3f81b20a9dbb54b5c66 Cr-Commit-Position: refs/heads/master@{#15196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/audio_processing/agc/agc_manager_direct.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
Per, PTAL.
4 years, 1 month ago (2016-11-22 14:35:48 UTC) #2
peah-webrtc
On 2016/11/22 14:35:48, hlundin-webrtc wrote: > Per, PTAL. Nice! lgtm
4 years, 1 month ago (2016-11-22 14:48:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522543006/1
4 years, 1 month ago (2016-11-22 14:49:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 15:02:49 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:03:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30a12fbbb9f89959b9a4f3f81b20a9dbb54b5c66
Cr-Commit-Position: refs/heads/master@{#15196}

Powered by Google App Engine
This is Rietveld 408576698