Now run EndToEndTest with the WebRTC-NewVideoJitterBuffer experiment.

webrtc/modules/video_coding/frame_object.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
+#include "webrtc/base/checks.h"
 #include "webrtc/modules/video_coding/frame_object.h"
 #include "webrtc/modules/video_coding/packet_buffer.h"
 
 namespace webrtc {
 namespace video_coding {
 
 FrameObject::FrameObject()
     : picture_id(0),
       spatial_layer(0),
       timestamp(0),
       num_references(0),
       inter_layer_predicted(false) {}
 
 RtpFrameObject::RtpFrameObject(PacketBuffer* packet_buffer,
                                uint16_t first_seq_num,
                                uint16_t last_seq_num,
                                size_t frame_size,
                                int times_nacked,
                                int64_t received_time)
     : packet_buffer_(packet_buffer),
       first_seq_num_(first_seq_num),
       last_seq_num_(last_seq_num),
       received_time_(received_time),
       times_nacked_(times_nacked) {
-  VCMPacket* packet = packet_buffer_->GetPacket(first_seq_num);
-  if (packet) {
-    // RtpFrameObject members
-    frame_type_ = packet->frameType;
-    codec_type_ = packet->codec;
+  VCMPacket* first_packet = packet_buffer_->GetPacket(first_seq_num);
+  RTC_DCHECK(first_packet);
 
-    // TODO(philipel): Remove when encoded image is replaced by FrameObject.
-    // VCMEncodedFrame members
-    CopyCodecSpecific(&packet->video_header);
-    _completeFrame = true;
-    _payloadType = packet->payloadType;
-    _timeStamp = packet->timestamp;
-    ntp_time_ms_ = packet->ntp_time_ms_;
+  // RtpFrameObject members
+  frame_type_ = first_packet->frameType;
+  codec_type_ = first_packet->codec;
 
-    // Since FFmpeg use an optimized bitstream reader that reads in chunks of
-    // 32/64 bits we have to add at least that much padding to the buffer
-    // to make sure the decoder doesn't read out of bounds.
-    // NOTE! EncodedImage::_size is the size of the buffer (think capacity of
-    //       an std::vector) and EncodedImage::_length is the actual size of
-    //       the bitstream (think size of an std::vector).
-    if (codec_type_ == kVideoCodecH264)
-      _size = frame_size + EncodedImage::kBufferPaddingBytesH264;
-    else
-      _size = frame_size;
+  // TODO(philipel): Remove when encoded image is replaced by FrameObject.
+  // VCMEncodedFrame members
+  CopyCodecSpecific(&first_packet->video_header);
+  _completeFrame = true;
+  _payloadType = first_packet->payloadType;
+  _timeStamp = first_packet->timestamp;
+  ntp_time_ms_ = first_packet->ntp_time_ms_;
 
-    _buffer = new uint8_t[_size];
-    _length = frame_size;
-    _frameType = packet->frameType;
-    GetBitstream(_buffer);
+  // Since FFmpeg use an optimized bitstream reader that reads in chunks of
+  // 32/64 bits we have to add at least that much padding to the buffer
+  // to make sure the decoder doesn't read out of bounds.
+  // NOTE! EncodedImage::_size is the size of the buffer (think capacity of
+  //       an std::vector) and EncodedImage::_length is the actual size of
+  //       the bitstream (think size of an std::vector).
+  if (codec_type_ == kVideoCodecH264)
+    _size = frame_size + EncodedImage::kBufferPaddingBytesH264;
+  else
+    _size = frame_size;
 
-    // FrameObject members
-    timestamp = packet->timestamp;
-  }
+  _buffer = new uint8_t[_size];
+  _length = frame_size;
+  _frameType = first_packet->frameType;
+  GetBitstream(_buffer);
+
+  // FrameObject members
+  timestamp = first_packet->timestamp;
+
+  VCMPacket* last_packet = packet_buffer_->GetPacket(last_seq_num);

[philipel, 2016/11/21 15:15:21]

Apparently the video rotation is set in the last packet of the frame...

[brandtr, 2016/11/21 16:46:45]

Is this according to the RFC, or just the way that we do it?

[sprang_webrtc, 2016/11/21 16:49:14]

Don't we set it on all packets? Or is it that we set it for each frame, even the
non-rotated ones? I seem to remember some oddities there. Maybe sync with
danilchap@ there.
Why do we always say that _rotation_set = true?

[philipel, 2016/11/22 14:56:23]

Added (copied from frame_buffer.cc) a comment about it.

[philipel, 2016/11/22 14:56:23]

Added comment, also, this piece of logic is copied from VCMFrameBuffer which
always set |_rotation_set| to true when a packet with a marker bit is inserted.

[sprang_webrtc, 2016/11/28 13:40:44]

Acknowledged.

+  RTC_DCHECK(last_packet && last_packet->markerBit);
+  rotation_ = last_packet->video_header.rotation;
+  _rotation_set = true;
 }
 
 RtpFrameObject::~RtpFrameObject() {
   packet_buffer_->ReturnFrame(this);
 }
 
 uint16_t RtpFrameObject::first_seq_num() const {
   return first_seq_num_;
 }
 
@@ skipping 32 matching lines @@
 rtc::Optional<RTPVideoTypeHeader> RtpFrameObject::GetCodecHeader() const {
   rtc::CritScope lock(&packet_buffer_->crit_);
   VCMPacket* packet = packet_buffer_->GetPacket(first_seq_num_);
   if (!packet)
     return rtc::Optional<RTPVideoTypeHeader>();
   return rtc::Optional<RTPVideoTypeHeader>(packet->video_header.codecHeader);
 }
 
 }  // namespace video_coding
 }  // namespace webrtc