Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2522083002: Fix module/desktop_capture compilation on iOS (Closed)

Created:
4 years, 1 month ago by Sergey Ulanov
Modified:
4 years, 1 month ago
Reviewers:
nicholss
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix module/desktop_capture compilation on iOS modules/desktop_capture was failing to compile on iOS because some files were not compiled. BUG=667898 R=nicholss@chromium.org Committed: https://crrev.com/1c062bf0af7662503217a57c118847c31f8a6ff5 Cr-Commit-Position: refs/heads/master@{#15203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sergey Ulanov
4 years, 1 month ago (2016-11-22 21:52:18 UTC) #2
nicholss
The change looks good and works for my remoting in bling build locally. I am ...
4 years, 1 month ago (2016-11-22 21:57:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522083002/1
4 years, 1 month ago (2016-11-22 23:25:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/8485)
4 years, 1 month ago (2016-11-22 23:40:33 UTC) #7
Sergey Ulanov
Committed patchset #1 (id:1) to pending queue manually as eb0ce36980ae3251756d36731b0d2b0f2419991b (presubmit successful).
4 years, 1 month ago (2016-11-23 00:07:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:07:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c062bf0af7662503217a57c118847c31f8a6ff5
Cr-Commit-Position: refs/heads/master@{#15203}

Powered by Google App Engine
This is Rietveld 408576698