Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2522073003: For VPN network, use the underlying network type as its type. (Closed)

Created:
4 years ago by honghaiz3
Modified:
4 years ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

For VPN network, use the underlying network type as its type. This is for Android. BUG=webrtc:6748 Committed: https://crrev.com/d44d0bae8507aaeead679d3b1e8a5283ab074f99 Cr-Commit-Position: refs/heads/master@{#15218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/api/android/java/src/org/webrtc/NetworkMonitorAutoDetect.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
honghaiz3
4 years ago (2016-11-22 22:09:08 UTC) #3
AlexG
lgtm
4 years ago (2016-11-22 22:24:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522073003/1
4 years ago (2016-11-23 00:58:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/builds/640)
4 years ago (2016-11-23 01:01:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522073003/1
4 years ago (2016-11-23 19:02:54 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 19:04:32 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-23 19:04:41 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d44d0bae8507aaeead679d3b1e8a5283ab074f99
Cr-Commit-Position: refs/heads/master@{#15218}

Powered by Google App Engine
This is Rietveld 408576698