Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2521183002:
Add an empty libjingle_peerconnection_metrics_default_jni target. (Closed)
|
Created:
4 years, 1 month ago by sakal Modified:
4 years, 1 month ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, philipel Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd an empty libjingle_peerconnection_metrics_default_jni target.
This allows downstream dependencies can add it as a dependency.
BUG=webrtc:6499
Committed: https://crrev.com/f72331205ddca18de7132817e22cb372a25589f2
Cr-Commit-Position: refs/heads/master@{#15178}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 ========== to ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 ==========
sakal@webrtc.org changed reviewers: + kjellander@webrtc.org
PTAL
lgtm if this builds (I suspect it fails). I had to even add a .cc file with actual code for the "webrtc" library at https://chromium.googlesource.com/external/webrtc/+/master/webrtc/BUILD.gn#224 to get it to build.
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2016/11/22 08:39:25, kjellander_webrtc wrote: > lgtm if this builds (I suspect it fails). > I had to even add a .cc file with actual code for the "webrtc" library at > https://chromium.googlesource.com/external/webrtc/+/master/webrtc/BUILD.gn#224 > to get it to build. Hmm, it builds fine on my local workstation. Let's see what the bots say.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479806632420500, "parent_rev":
"ef686433d9a8993a3eea1147de9d309beca2d1c6", "commit_rev":
"4b9384f7a899e7cdf98687b30adccf9849c2c0d5"}
Message was sent while issue was closed.
Description was changed from ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 ========== to ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 ========== to ========== Add an empty libjingle_peerconnection_metrics_default_jni target. This allows downstream dependencies can add it as a dependency. BUG=webrtc:6499 Committed: https://crrev.com/f72331205ddca18de7132817e22cb372a25589f2 Cr-Commit-Position: refs/heads/master@{#15178} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f72331205ddca18de7132817e22cb372a25589f2 Cr-Commit-Position: refs/heads/master@{#15178} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
