iOS AppRTCMobile: Fix SDP video codec reordering for multiple H264 profiles

webrtc/examples/objc/AppRTCMobile/tests/ARDAppClientTest.mm

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 340 matching lines @@
   }];
 }
 
 @end
 
 @interface ARDSDPUtilsTest : ARDTestCase
 - (void)testPreferVideoCodec;
 @end
 
 @implementation ARDSDPUtilsTest
 

[daniela-webrtc, 2016/11/21 16:23:00]

Perhaps few more tests can be added.
For instance one for the use case when the m=video string is missing, and few to
actually test the order of the preferred codecs.

[magjed_webrtc, 2016/11/22 14:40:24]

Done, I added some more tests.

 - (void)testPreferVideoCodec {
-  NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120\n"
-                    "a=rtpmap:120 H264/90000\n");
-  NSString *expectedSdp = @("m=video 9 RTP/SAVPF 120 100 116 117 96\n"
-                            "a=rtpmap:120 H264/90000\n");
+  NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\n"
+                    "a=rtpmap:120 H264/90000\n"
+                    "a=rtpmap:97 H264/90000\n");
+  NSString *expectedSdp = @("m=video 9 RTP/SAVPF 120 97 100 116 117 96\n"
+                            "a=rtpmap:120 H264/90000\n"
+                            "a=rtpmap:97 H264/90000\n");
   RTCSessionDescription* desc =
       [[RTCSessionDescription alloc] initWithType:RTCSdpTypeOffer sdp:sdp];
   RTCSessionDescription *h264Desc =
       [ARDSDPUtils descriptionForDescription:desc
                          preferredVideoCodec:@"H264"];
   EXPECT_TRUE([h264Desc.description rangeOfString:expectedSdp].location != NSNotFound);
 }
 
 @end
 
@@ skipping 28 matching lines @@
   @autoreleasepool {
     ARDSDPUtilsTest *test = [[ARDSDPUtilsTest alloc] init];
     [test testPreferVideoCodec];
   }
 }
 
 int main(int argc, char **argv) {
   ::testing::InitGoogleTest(&argc, argv);
   return RUN_ALL_TESTS();
 }