Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2520533002: Remove unused dbus.cc/.h and related things. (Closed)

Created:
4 years, 1 month ago by the sun
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused dbus.cc/.h and related things. BUG=webrtc:6829 Committed: https://crrev.com/01af3a352c24cba8db9b186f2a1a5107e9297ead Cr-Commit-Position: refs/heads/master@{#15155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -906 lines) Patch
M webrtc/BUILD.gn View 2 chunks +0 lines, -16 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/base/dbus.h View 1 chunk +0 lines, -168 lines 0 comments Download
D webrtc/base/dbus.cc View 1 chunk +0 lines, -401 lines 0 comments Download
D webrtc/base/dbus_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D webrtc/base/libdbusglibsymboltable.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/base/libdbusglibsymboltable.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
the sun
4 years, 1 month ago (2016-11-18 21:04:30 UTC) #2
tommi
lgtm
4 years, 1 month ago (2016-11-18 22:35:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2520533002/1
4 years, 1 month ago (2016-11-18 22:36:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 22:52:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01af3a352c24cba8db9b186f2a1a5107e9297ead Cr-Commit-Position: refs/heads/master@{#15155}
4 years, 1 month ago (2016-11-18 22:52:32 UTC) #8
kjellander_webrtc
4 years ago (2016-11-21 07:08:14 UTC) #9
Message was sent while issue was closed.
lgtm, although I don't even remember what this was used for.

Powered by Google App Engine
This is Rietveld 408576698