Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2520323002: Created an AudioMixer mock in webrtc/api/test. (Closed)

Created:
4 years, 1 month ago by aleloi
Modified:
4 years, 1 month ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Created an AudioMixer mock in webrtc/api/test. The mock is used in a dependent CL https://codereview.webrtc.org/2436033002. There is also a goal to allow external mixing implementations (subclasses of webrtc::AudioMixer) and inject them to PeerConnectionFactory. We think that part of that is an official and maintained mock. Summary of changes: * Created a mixer mock/stub in webrtc/api/test * Made a target webrtc/api:mock_audio_mixer for it. NOTRY=True BUG=webrtc:6346 Committed: https://crrev.com/17338d41ac5bd3b5121c8f1ca2e077afee16ab70 Cr-Commit-Position: refs/heads/master@{#15190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A webrtc/api/test/mock_audio_mixer.h View 1 chunk +32 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
aleloi
Hi! Here is a small one. Could you take a look?
4 years, 1 month ago (2016-11-22 13:26:23 UTC) #3
henrika_webrtc
LGTM
4 years, 1 month ago (2016-11-22 13:33:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2520323002/1
4 years, 1 month ago (2016-11-22 14:00:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 14:02:09 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 14:02:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17338d41ac5bd3b5121c8f1ca2e077afee16ab70
Cr-Commit-Position: refs/heads/master@{#15190}

Powered by Google App Engine
This is Rietveld 408576698