Reland "Move smoothing filter to common audio".

Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to reland it.

BUG=webrtc:6443
Committed: https://crrev.com/223641f1b903e41e77d88f03199b4cdb65255ec8
Cr-Commit-Position: refs/heads/master@{#15227}

[minyue-webrtc, 2016-11-23 11:18:45]

Patchset #3 (id:40001) has been deleted

[minyue-webrtc, 2016-11-23 12:49:13]

Description was changed from

==========
Revert "Revert of Move smoothing filter to common audio. (patchset #3 id:60001
of https://codereview.webrtc.org/2484153002/ )"

This reverts commit d7ac0a9bcc5e9ff0eaf575ae3c886c0df92978f9.

BUG=
==========

to

==========
Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to
reland it.

BUG=webrtc:6443
==========

[minyue-webrtc, 2016-11-23 12:49:13]

minyue@webrtc.org changed reviewers:
+ solenberg@webrtc.org, terelius@webrtc.org, tommi@webrtc.org

[minyue-webrtc, 2016-11-23 12:51:43]

Hi Reviewers,

Please take a look at this CL.

It is titled Reland "..." but it does more. I followed offline discussion and
moved the source into base/analytics and created rtc_analytics. See PS2.

In PS3, I add dependency at various places and it passes our internal bots now.

[terelius, 2016-11-23 14:19:23]

lgtm. I am fine with landing this as-is, but I have some questions/comments.

I am not a fan of calling it analytics. To me it sounds like analytics for call
quality and similar usage statistics
(https://en.wikipedia.org/wiki/Software_analytics). While this class could be
used in that sense, it currently has a more functional role.

When I spoke with solenberg, he suggested putting a BUILD.gn file in each
subfolder in base/. What do you think about it minyue?

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:343: ]
Should this depend on base_approved?

[minyue-webrtc, 2016-11-24 08:44:55]

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:343: ]
On 2016/11/23 14:19:23, terelius wrote:
> Should this depend on base_approved?

Oh, thanks, the exp_filter uses the follow. So it should.

constructormagic / optional / system_clock

[minyue-webrtc, 2016-11-24 10:26:03]

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2520003005/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:343: ]
On 2016/11/24 08:44:55, minyue-webrtc wrote:
> On 2016/11/23 14:19:23, terelius wrote:
> > Should this depend on base_approved?
> 
> Oh, thanks, the exp_filter uses the follow. So it should.
> 
> constructormagic / optional / system_clock

Oh, I might have looked at a wrong source yesterday (smoothing_filter.h|cc)
which depends on these. exp_filter is very clean and don't need any of them.

[minyue-webrtc, 2016-11-24 10:36:06]

Hi reviewers,

I now moved the new to the subfolder per offline discussion.

[tommi, 2016-11-24 10:47:33]

lgtm

[the sun, 2016-11-24 11:20:29]

solenberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[the sun, 2016-11-24 11:20:30]

lgtm

kjellander@ - should there be a DEPS file in base/analytics/ ? I guess it'd be
empty for now though.

https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
File webrtc/base/analytics/exp_filter_unittest.cc (right):

https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
webrtc/base/analytics/exp_filter_unittest.cc:14: #include "webrtc/base/gunit.h"
#include "webrtc/test/gtest.h"
instead?

[kjellander_webrtc, 2016-11-24 12:36:20]

On 2016/11/24 11:20:30, the sun wrote:
> lgtm
> 
> kjellander@ - should there be a DEPS file in base/analytics/ ? I guess it'd be
> empty for now though.

There's no need for a DEPS file in every dir. Since there is one in webrtc/base
already I think it's fine to use that one unless the dependencies of the
analytics dir is dramatically different and you really want to protect future
users from pulling in undesired dependencies.

> 
>
https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
> File webrtc/base/analytics/exp_filter_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
> webrtc/base/analytics/exp_filter_unittest.cc:14: #include
"webrtc/base/gunit.h"
> #include "webrtc/test/gtest.h"
> instead?

Right, it would probably benefit us if we got rid of that old gunit.h header
(it's relic from the libjingle days).

[minyue-webrtc, 2016-11-24 12:52:00]

https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
File webrtc/base/analytics/exp_filter_unittest.cc (right):

https://codereview.webrtc.org/2520003005/diff/80001/webrtc/base/analytics/exp...
webrtc/base/analytics/exp_filter_unittest.cc:14: #include "webrtc/base/gunit.h"
On 2016/11/24 11:20:29, the sun wrote:
> #include "webrtc/test/gtest.h"
> instead?

Done.

[minyue-webrtc, 2016-11-24 12:52:48]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 12:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-24 12:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 12:58:09]

Dry run: Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15184)

[minyue-webrtc, 2016-11-24 13:07:51]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 13:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-24 13:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:13:11]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2016-11-24 14:06:14]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-11-24 14:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org,
solenberg@webrtc.org, tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2520003005/#ps100001 (title:
"fixing an old error in exp_filter")

[commit-bot: I haz the power, 2016-11-24 14:06:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-24 14:08:05]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479996374789270,
"parent_rev": "eabd5440184e941eca93f9a0b65bdbca69132208", "commit_rev":
"92844ae0c150c047544b6e8ba5664b89f8d8a5a2"}

[commit-bot: I haz the power, 2016-11-24 14:08:08]

Description was changed from

==========
Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to
reland it.

BUG=webrtc:6443
==========

to

==========
Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to
reland it.

BUG=webrtc:6443
==========

[commit-bot: I haz the power, 2016-11-24 14:08:12]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-11-24 14:08:17]

Description was changed from

==========
Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to
reland it.

BUG=webrtc:6443
==========

to

==========
Reland "Move smoothing filter to common audio".

The original CL was this https://codereview.webrtc.org/2484153002/

Due to failure with internal trial servers, it was reverted. This CL tries to
reland it.

BUG=webrtc:6443

Committed: https://crrev.com/223641f1b903e41e77d88f03199b4cdb65255ec8
Cr-Commit-Position: refs/heads/master@{#15227}
==========

[commit-bot: I haz the power, 2016-11-24 14:08:18]

Patchset 5 (id:??) landed as
https://crrev.com/223641f1b903e41e77d88f03199b4cdb65255ec8
Cr-Commit-Position: refs/heads/master@{#15227}

[minyue-webrtc, 2016-11-24 15:13:01]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.webrtc.org/2529943002/ by minyue@webrtc.org.

The reason for reverting is: Internal bots failed..

[minyue-webrtc, 2016-11-24 15:15:04]

On 2016/11/24 15:13:01, minyue-webrtc wrote:
> A revert of this CL (patchset #5 id:100001) has been created in
> https://codereview.webrtc.org/2529943002/ by mailto:minyue@webrtc.org.
> 
> The reason for reverting is: Internal bots failed..

Clearly, the splitting of BUILD.gn into the subfolder caused some problem. I am
investigating.