ComfortNoise: Calculate used scale factor in Q13

ComfortNoise: Calculate used scale factor in Q13

BUG=chromium:666518
Committed: https://crrev.com/0eb19602a3a7bab20f31efe93f9de205106f5b48
Cr-Commit-Position: refs/heads/master@{#15189}

[ossu, 2016-11-21 14:02:53]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 14:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-21 14:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:21:49]

Dry run: This issue passed the CQ dry run.

[ossu, 2016-11-21 14:40:50]

ossu@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[ossu, 2016-11-21 14:40:50]

This bug addresses a recent fuzzer bug. It seems we can circumvent the whole
problem by just doing the calculation in Q13 rather than scaling to, and then
calculate in, Q15. The bitexactness tests still check out, so the slightly lower
precision doesn't seem to matter.

[hlundin-webrtc, 2016-11-22 12:44:43]

LGTM with one comment-comment.

https://codereview.webrtc.org/2519873003/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/cng/webrtc_cng.cc (right):

https://codereview.webrtc.org/2519873003/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/cng/webrtc_cng.cc:122: int16_t Beta, BetaC;
Please, annotate that these are in Q15.

[ossu, 2016-11-22 12:59:37]

The CQ bit was checked by ossu@webrtc.org

[ossu, 2016-11-22 12:59:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2519873003/#ps20001 (title:
"One more comment.")

[commit-bot: I haz the power, 2016-11-22 12:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 13:15:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479819577310070,
"parent_rev": "10ed3507d1133be61103591ff64c4222a1bc5653", "commit_rev":
"cefb5c729dced29f609c74bf9dc186fe7c4cd3f0"}

[commit-bot: I haz the power, 2016-11-22 13:15:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 13:15:35]

Description was changed from

==========
ComfortNoise: Calculate used scale factor in Q13

BUG=chromium:666518
==========

to

==========
ComfortNoise: Calculate used scale factor in Q13

BUG=chromium:666518

Committed: https://crrev.com/0eb19602a3a7bab20f31efe93f9de205106f5b48
Cr-Commit-Position: refs/heads/master@{#15189}
==========

[commit-bot: I haz the power, 2016-11-22 13:15:36]

Patchset 2 (id:??) landed as
https://crrev.com/0eb19602a3a7bab20f31efe93f9de205106f5b48
Cr-Commit-Position: refs/heads/master@{#15189}