webrtc/voice_engine/voe_codec_impl.cc - Issue 2518923003: Pass time constant to bwe smoothing filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/voe_codec_impl.cc

Issue 2518923003: Pass time constant to bwe smoothing filter. (Closed)

Patch Set: Add probing_interval_ms to NullBitrateObserver. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/voice_engine/voe_codec_impl.cc

diff --git a/webrtc/voice_engine/voe_codec_impl.cc b/webrtc/voice_engine/voe_codec_impl.cc

index 8ac24da4e7974ec893987b531d048799f3299937..b2fd08d599b60cb17cf793cea53aca5cdb0c90b5 100644

--- a/webrtc/voice_engine/voe_codec_impl.cc

+++ b/webrtc/voice_engine/voe_codec_impl.cc

@@ -137,8 +137,9 @@ int VoECodecImpl::SetBitRate(int channel, int bitrate_bps) {

_shared->SetLastError(VE_NOT_INITED, kTraceError);

return -1;

}

+ constexpr int64_t kDefaultProbingIntervalMs = 3000;

_shared->channel_manager().GetChannel(channel).channel()->SetBitRate(

- bitrate_bps);

+ bitrate_bps, kDefaultProbingIntervalMs);

return 0;

}